feat: gomod private repo support #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Jan 23, 2026
js-murph
added a commit
that referenced
this pull request
Jan 26, 2026
# What? Migrates the git clone component of the git strategy into a separate API # Why? Experimentation on implementing private repo support for the gomod strategy in #56 revealed we are likely better off separating the git clone behaviour so that it can be shared between multiple strategies.
Co-authored-by: Alec Thomas <aat@block.xyz>
Co-authored-by: Alec Thomas <aat@block.xyz>
js-murph
force-pushed
the
johnm/goproxy-private-repo-support
branch
from
e4569a0 to
2a077c9
Compare
Open
alecthomas
approved these changes
Jan 29, 2026
Collaborator
alecthomas
left a comment
alecthomas
left a comment
There was a problem hiding this comment.
How are we testing this, do we have a way?
Comment on lines
+73
to
+77
| homeDir, err := os.UserHomeDir() | ||
| if err != nil { | ||
| return nil, errors.Wrap(err, "get user home directory") | ||
| } | ||
| mirrorRoot = filepath.Join(homeDir, ".cache", "cachew", "gomod-git-mirrors") |
Collaborator
There was a problem hiding this comment.
We should require a config path so we can put all state into a single directory, like we do with the other git mirrors.
Also remind me again why we can't reuse our existing git mirrors?
| } | ||
|
|
||
| // Create gitclone manager for private repositories | ||
| cloneManager, err := gitclone.NewManager(ctx, gitclone.Config{ |
Collaborator
There was a problem hiding this comment.
We should construct the gitclone manager in main and inject it into the gomod strategy. This'll require some refactoring of the factory functions, so I'll do that post merge.
| f, err := w.Create(prefix + "go.mod") | ||
| assert.NoError(t, err) | ||
| if err != nil { | ||
| panic(err) |
Collaborator
There was a problem hiding this comment.
Not sure why this was changed, but the old behaviour was correct - we should never panic in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds support for private gomod repositories via github. This builds on the existing git caching capabilities within Cachew.
Why?
So that we are able to cache private go modules.
Tests
Unit testing has been added, but manual verification has also been performed...
First create a configuration:
Then test a private repository.